fix nwis_client bug causing KeyError when station does not return data #134
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #133 for the bug report. This PR resolves #133. Now, when a station does not have data,
nwis_client
returns a canonical dataframe with the correct data types to the user. Additionally, the user is warned that the request did not return data.fixes #133
Additions
_create_empty_canonical_df
)Removals
Changes
nwis_client.get
returns a canonical dataframe with the correct data types in cases when no data is retrieved from nwis.Testing
test_get_returns_empty_canonical_dataframe
added. Uses mock to verify a canonical dataframe is returned.Checklist