Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LGAR-C workflow for automated tests #15

Merged
merged 16 commits into from
Jan 8, 2024

Conversation

stcui007
Copy link
Contributor

@stcui007 stcui007 commented Dec 22, 2023

The workflows provide automated tests for new commits of codes when a pull request is created. This provides an additional layer of assurance of the commited codes' correctness.

The tests of the workflow codes are performed here: stcui007#1

Additions

.github/workflows/build_and_run_tests.yml
.github/workflows/ngen_integration.yaml
realizations/realization_config_lasam_ngenCI.json
realizations/realization_config_lasam_cft_ngenCI.json
realizations/realization_config_lasam_smp_ngenCI.json

Removals

Changes

Testing

Tests have been run on my branch, see the link below:
stcui007#1

Screenshots

Notes

Todos

Checklist

  • [x ] PR has an informative and human-readable title
  • [x ] Changes are limited to a single goal (no scope creep)
  • [x ] Code can be automatically merged (no conflicts)
  • [x ] Code follows project standards (link if applicable)
  • [x ] Passes all existing automated tests
  • [x ] Any change in functionality is tested
  • [x ] New functions are documented (with a description, list of inputs, and expected output)
  • [x ] Placeholder code is flagged / future todos are captured in comments
  • Visually tested in supported browsers and devices (see checklist below 👇)
  • Project documentation has been updated (including the "Unreleased" section of the CHANGELOG)
  • Reviewers requested with the Reviewers tool ➡️

Testing checklist

Target Environment support

  • Windows
  • [x ] Linux
  • Browser

Accessibility

  • Keyboard friendly
  • Screen reader friendly

Other

  • Is useable without CSS
  • Is useable without JS
  • Flexible from small to large screens
  • No linting errors or warnings
  • JavaScript tests are passing

@stcui007 stcui007 marked this pull request as ready for review January 4, 2024 17:06
Copy link
Collaborator

@ajkhattak ajkhattak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me. One thing for future, the example .json files and ngenCI json files only differ in "library_file" paths, later we can make them consistent to keep just one json file.

.github/workflows/build_and_run_tests.yml Outdated Show resolved Hide resolved
@stcui007
Copy link
Contributor Author

stcui007 commented Jan 8, 2024 via email

@ajkhattak ajkhattak merged commit 53c0d3e into NOAA-OWP:master Jan 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants