generated from NOAA-OWP/owp-open-source-project-template
-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
LGAR-C workflow for automated tests #15
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stcui007
requested review from
program--,
ajkhattak,
PhilMiller and
hellkite500
January 4, 2024 17:00
ajkhattak
approved these changes
Jan 8, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me. One thing for future, the example .json files and ngenCI json files only differ in "library_file" paths, later we can make them consistent to keep just one json file.
Thanks for the comments. I'll put detailed replies in the PR page.
…On Mon, Jan 8, 2024 at 1:21 PM AhmadJan-NOAA ***@***.***> wrote:
***@***.**** approved this pull request.
This looks good to me. One thing for future, the example .json files and
ngenCI json files only differ in "library_file" paths, later we can make
them consistent to keep just one json file.
------------------------------
In .github/workflows/build_and_run_tests.yml
<#15 (comment)>:
> + - name: Build and Run Standalone
+ run: |
+ mkdir build && cd build
+ cmake ../ -DSTANDALONE=ON
+ make && cd ..
+ ./build/lasam_standalone configs/config_lasam_Phillipsburg.txt
+ ./build/lasam_standalone configs/config_lasam_Bushland.txt
can you please move this to the end, 1. unittest, 2. synthetic tests, 3.
real tests (just to be consistent)
—
Reply to this email directly, view it on GitHub
<#15 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ACA4SRJBDUYKA6DIDLASEODYNRBJ5AVCNFSM6AAAAABBAIRTTOVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMYTQMBZHA2DSOJSGI>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
ajkhattak
approved these changes
Jan 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The workflows provide automated tests for new commits of codes when a pull request is created. This provides an additional layer of assurance of the commited codes' correctness.
The tests of the workflow codes are performed here: stcui007#1
Additions
.github/workflows/build_and_run_tests.yml
.github/workflows/ngen_integration.yaml
realizations/realization_config_lasam_ngenCI.json
realizations/realization_config_lasam_cft_ngenCI.json
realizations/realization_config_lasam_smp_ngenCI.json
Removals
Changes
Testing
Tests have been run on my branch, see the link below:
stcui007#1
Screenshots
Notes
Todos
Checklist
Testing checklist
Target Environment support
Accessibility
Other