Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ugwp v1 #41

Closed
wants to merge 2 commits into from
Closed

Ugwp v1 #41

wants to merge 2 commits into from

Conversation

mdtoy
Copy link

@mdtoy mdtoy commented Jul 8, 2020

Hi Dom,

Here is the draft pull request (2 of 3) for helping out with my UGWP_v1 CCPP conversion.

Thank you,
Mike

hannahcbarnes pushed a commit to hannahcbarnes/fv3atm that referenced this pull request Jul 15, 2020
* netcdf parallel writing and lon/lat in netcdf file

* some changes to get it to (almost) run on hera

* lat should be in degrees - remove conversion to radians.

* import updates from jswhit/fv3atm

* more bug fixes - now works on hera

* specify collective access if compression turned on.

* use classic model

* bug fixes for parallel IO with compression

* fix calculation of max compression error

* turn off shuffle filter

* code simplification

* remove debug print

* don't use parallel IO for 2d file (since it seems to increase run time)

* allow multiple values of output_file, as long as they all start with 'netcdf'

* use default chunksize for 2d vars

* delete commented out macro ESMF_ERR_ABORT

* delete rad2dg

* add module_write_netcdf_parallel.F90

* add option to build without parallel netcdf (-DNO_PARALLEL_NETCDF)

* fix typo

* stub file for building without parallel netcdf lib

* allow chunksizes for 2d arrays to be set in model_configure (ichunk2d,jchunk2d)
Default is size of array on each write task.

* add ichunk3d,jchunk3d,kchunk3d to specify 3d chunksizes.
Default is now ichunk3d,jchunk3d same as array size on each PE, kchunk3d=nlevs
This results in the fastest writes on hera.

* fix typo

* put ifdefs in module_write_netcdf_parallel.F90 so no stub file needed

* don't need this file anymore

* remove module_write_netcdf_parallel_stub.o target

* use specified chunksizes for serial IO. If chunksize parameter negative, let netcdf library choose defaults.

* update comments

* get output_file without esmf call error

* syntax fix

* fix stub interface in module_write_netcdf_parallel.F90 for cmake build

Co-authored-by: junwang-noaa <[email protected]>
Copy link

@climbfuji climbfuji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me.

@DomHeinzeller
Copy link

This PR will be replaced.

SamuelTrahanNOAA pushed a commit to tanyasmirnova/fv3atm that referenced this pull request Mar 24, 2023
… submodule pointer update for NOAA-EMC#462 (NOAA-EMC#634)

* add nssl_alphar, nssl_ehw0_in, nssl_ehlw0_in to namelist entries for ensemble perturbationsons

* update the standard name for hail/graupel collection efficiency

* update the long names for parameters related to NSSL microphysics

* update ccpp/physics and ccpp/framework submodule pointers

---------

Co-authored-by: Jili Dong <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants