Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge radar_tten support for the tenth time. #119

Conversation

SamuelTrahanNOAA
Copy link
Collaborator

Temperature tendencies in microphysics scheme replaced with radar-derived values for the first N minutes of the model run.

url = https://github.com/NOAA-GSL/ccpp-physics
branch = gsl/develop
url = https://github.com/SamuelTrahanNOAA/ccpp-physics
branch = feature/gsl-develop-20211203-radar-tten
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This points to your branch. Is this intended? If Yes, you will change this later, right?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. You have to do this until a merge so people can clone your branch from the ufs-weather-model level.

@climbfuji
Copy link

Note that we should update gsl/develop from the authoritative repositories first before we merge this PR. This is so that we have a version/hash that is 100% identical with the authoritative repository as of beginning of this week.

@SamuelTrahanNOAA
Copy link
Collaborator Author

Note that we should update gsl/develop from the authoritative repositories first before we merge this PR. This is so that we have a version/hash that is 100% identical with the authoritative repository as of beginning of this week.

Yes. Or perhaps I should do a new PR to the community repositories instead?

Either way, someone will have to retest this.

@hu5970
Copy link

hu5970 commented Dec 15, 2021

Sam, I can test it again when you have a new PR.

@hu5970
Copy link

hu5970 commented Dec 15, 2021

@climbfuji
I can see you merged gsl/develp branch to community develop branch on December 13, 2021 with hash:
56f3483

The gsl/develop branch is still on November 24, 2021 with hash:
0409aa0

Those two are identical, right?
I can see the version is identical but why did you say the hash is identical?

Thanks,
Ming

@climbfuji
Copy link

@climbfuji I can see you merged gsl/develp branch to community develop branch on December 13, 2021 with hash: 56f3483

The gsl/develop branch is still on November 24, 2021 with hash: 0409aa0

Those two are identical, right? I can see the version is identical but why did you say the hash is identical?

Thanks, Ming

They are not. The Dec 13 hash has changes from the authoritative repositories that have not been merged into gsl/develop yet, in particular the entire revamp of the GSL/RAP regression tests.

@SamuelTrahanNOAA
Copy link
Collaborator Author

Closing this so I can do a PR to the community repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants