Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace hard-coded parameter Rrho0 with runtime parameter Max_Rrho_sa… #746

Merged
merged 1 commit into from
Nov 5, 2024
Merged

Replace hard-coded parameter Rrho0 with runtime parameter Max_Rrho_sa… #746

merged 1 commit into from
Nov 5, 2024

Commits on Nov 5, 2024

  1. Replace hard-coded parameter Rrho0 with runtime parameter Max_Rrho_sa… 

    …lt_fingers

- Double diffusion code was updated to include runtime parameter for maximum density ratio, but it was never implemented in the actual calculation of the double diffusion diffusivities.  It is now used in the calculation and Rrho0 is removed from the code.
- The default value of Max_Rrho_salt_fingers is changed from 2.55 to 1.9 to avoid changing behavior from the old code.  However, it should be updated to 2.55 and noted that it will change answers for any run with double diffusion enabled through MOM6.  It does not affect the behavior of double diffusion enabled through CVMix.
    @breichl @adcroft
    breichl authored and adcroft committed Nov 5, 2024
    Configuration menu
    Copy the full SHA
    090254e View commit details
    Browse the repository at this point in the history