Revert a bug fix with visc_rem in continuity solver #745
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hallberg-NOAA
approved these changes
Nov 4, 2024
Hallberg-NOAA
added
bug
This particular bugfix was proved to be unnecessary and therefore incorrectly added. Runtime parameter VISC_REM_BUG now controls two bugfixes, related to RK2 time stepping and barotropic vertical weight, which are valid.
VISC_REM_TIMESTEP_FIX -> VISC_REM_TIMESTEP_BUG VISC_REM_BT_WEIGHT_FIX -> VISC_REM_BT_WEIGHT_BUG The "signs" of the flags are flipped accordingly.
adcroft
force-pushed
the
remove_visc_rem_hvel
branch
from
5759245
to
341caf4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR reverts a bug fix introduced previously #639, related to using
visc_rem_[uv]for vertical weightsfrhat[uv]in barotropic solver. The change (controlled by runtime parameterVISC_REM_CONT_HVEL_FIX), was demonstrated to be incorrect. Therefore the "fix" is unnecessary.The other two bug fixes introduced at the same time are still valid. Corresponding runtime parameter names are changed with a suffix "_bug" for consistency.
This PR introduces no answer changes. There are changes in runtime parameters with one removal and three name/description changes.