forked from mom-ocean/MOM6
-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Separate scalar diagnostics for each ice sheet + parameters to control ice-sheet velocities #714
Merged
Hallberg-NOAA
merged 6 commits into
NOAA-GFDL:dev/gfdl
from
alex-huth:iOM4_with_bergs_merge_dev/gfdl
Sep 18, 2024
Merged
Separate scalar diagnostics for each ice sheet + parameters to control ice-sheet velocities #714
Hallberg-NOAA
merged 6 commits into
NOAA-GFDL:dev/gfdl
from
alex-huth:iOM4_with_bergs_merge_dev/gfdl
Sep 18, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hallberg-NOAA
approved these changes
Sep 18, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These changes all seem reasonable to me.
…min basal traction, max surf slope, and min ice viscosity to use for ice dynamics
…yr], but converts automatically to [Pa m-1 s] in the code
…ace slope fields used in the shallow shelf approximation (SSA). This is particularly helpful for determining whether unrealistic velocities are caused by unrealistically steep surface slopes, which can sometimes arise for example, on coarse grid cells that cover both a steep mountainous region and a realively flat ice shelf. Then, the MAX_SURFACE_SLOPE parameter can be tuned to set an upper bound on the SSA surface slope to avoid these steep-slope-induced problematic velocities.
Hallberg-NOAA
force-pushed
the
iOM4_with_bergs_merge_dev/gfdl
branch
from
September 18, 2024 14:46
54fdbbf
to
7c18900
Compare
theresa-morrison
pushed a commit
to theresa-morrison/MOM6
that referenced
this pull request
Nov 18, 2024
…l ice-sheet velocities (NOAA-GFDL#714) * Updated with dev/gfdl. Then, added parameters for min ice thickness, min basal traction, max surf slope, and min ice viscosity to use for ice dynamics * noted how the MIN_BASAL_TRACTION parameter input is in units [Pa m-1 yr], but converts automatically to [Pa m-1 s] in the code * Added separate scalar ice-shelf diagnostics for Antarctica and Greenland * Added sx_shelf and sy_shelf as ice shelf diagnostics to save the surface slope fields used in the shallow shelf approximation (SSA). This is particularly helpful for determining whether unrealistic velocities are caused by unrealistically steep surface slopes, which can sometimes arise for example, on coarse grid cells that cover both a steep mountainous region and a realively flat ice shelf. Then, the MAX_SURFACE_SLOPE parameter can be tuned to set an upper bound on the SSA surface slope to avoid these steep-slope-induced problematic velocities. * Fix doxygen errors for ice-sheet process_and_post_scalar_data routine * FMA fix associated with enforcement of max allowed ice-shelf surface slope
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds area-integrated scalar diagnostics for ice sheets that may be requested separately for Antarctica-only (where lat<0) and/or Greenland-only (where lat>0). The previous approach, which simply integrated quantities over all ice area present in the domain, is still available for polar stereographic or idealized simulations.
This PR also adds a few ice-sheet parameters: MIN_H_SHELF, MIN_BASAL_TRACTION, MAX_SURFACE_SLOPE, and MIN_ICE_VISC. These parameters temporarily adjust the ice thickness, basal traction, surface slope, and ice viscosity, respectively, during the ice dynamics (shallow shelf approximation) solve, which helps avoid unrealistically large ice speeds (e.g. in coastal areas with very steep topography).
Also added ice-shelf surface slopes (sx_shelf, sy_shelf) as diagnostic fields