Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document 31 real variables units #514

Merged

Conversation

Hallberg-NOAA
Copy link
Member

Added standard-format unit descriptions for 31 real variables in comments scattered across 14 modules in the core, tracer, and both parameterizations directories. Only comments are changed and all answers are bitwise identical.

This a limited subset of the changes in (/pull/510) with one of the altered files omitted to avoid creating a conflict if the dimensional consistencies in that file are corrected via dev/ncar rather than dev/gfdl.

  Added standard-format unit descriptions for 31 real variables in comments
scattered across 14 modules in the core, tracer, and both parameterizations
directories.  Only comments are changed and all answers are bitwise identical.
@codecov
Copy link

codecov bot commented Oct 30, 2023

Codecov Report

Merging #514 (5edbb9f) into dev/gfdl (19f0147) will increase coverage by 0.00%.
The diff coverage is 33.33%.

❗ Current head 5edbb9f differs from pull request most recent head 2fab7c0. Consider uploading reports for the commit 2fab7c0 to get more accurate results

@@            Coverage Diff            @@
##           dev/gfdl     #514   +/-   ##
=========================================
  Coverage     37.52%   37.52%           
=========================================
  Files           270      270           
  Lines         79064    79064           
  Branches      14630    14630           
=========================================
+ Hits          29670    29672    +2     
+ Misses        43928    43926    -2     
  Partials       5466     5466           
Files Coverage Δ
src/core/MOM_barotropic.F90 58.17% <ø> (ø)
src/core/MOM_forcing_type.F90 40.87% <ø> (ø)
src/core/MOM_grid.F90 75.59% <ø> (ø)
src/core/MOM_interface_heights.F90 25.40% <100.00%> (ø)
...ameterizations/lateral/MOM_mixed_layer_restrat.F90 70.03% <ø> (ø)
...arameterizations/lateral/MOM_thickness_diffuse.F90 46.15% <ø> (ø)
...rc/parameterizations/lateral/MOM_tidal_forcing.F90 39.56% <ø> (ø)
...c/parameterizations/vertical/MOM_energetic_PBL.F90 52.48% <ø> (ø)
src/parameterizations/vertical/MOM_opacity.F90 33.59% <ø> (ø)
src/tracer/MOM_CFC_cap.F90 16.33% <ø> (ø)
... and 4 more

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@marshallward
Copy link
Member

Gaea regression: https://gitlab.gfdl.noaa.gov/ogrp/MOM6/-/pipelines/21164 ✔️

@marshallward marshallward merged commit ffa6af6 into NOAA-GFDL:dev/gfdl Oct 31, 2023
10 checks passed
@Hallberg-NOAA Hallberg-NOAA deleted the various_units_in_comments branch November 8, 2023 23:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants