(+*) Fix bugs in tracer index in tracer reservoirs

[WenhaoChen89]

The tracers in the tracer registry (tracer_registry_type), the segment tracer registry (OBC_segment_tracer_type), and the OBC input fields (OBC_segment_data_type) are different. Therefore, they are using different indices and orders. However, in the function update_segment_tracer_reservoirs and tracer advection, all tracers including OBC_segment_tracer_type and OBC_segment_data_typeare looped through the indices and orders of the tracer_registry_type. This pull request is to fix this bug.

[codecov]

Codecov Report

Merging #480 (1e4eda6) into dev/gfdl (bd4c87c) will decrease coverage by 0.02%.
The diff coverage is 0.00%.

❗ Current head 1e4eda6 differs from pull request most recent head 2541f45. Consider uploading reports for the commit 2541f45 to get more accurate results

@@             Coverage Diff              @@
##           dev/gfdl     #480      +/-   ##
============================================
- Coverage     37.79%   37.78%   -0.02%     
============================================
  Files           270      270              
  Lines         78404    78431      +27     
  Branches      14521    14525       +4     
============================================
+ Hits          29636    29638       +2     
- Misses        43364    43389      +25     
  Partials       5404     5404              

Files	Coverage Δ
src/user/dyed_channel_initialization.F90	0.00% <0.00%> (ø)
src/user/dyed_obcs_initialization.F90	0.00% <0.00%> (ø)
src/tracer/MOM_tracer_registry.F90	64.12% <0.00%> (-0.41%)	⬇️
src/user/DOME_initialization.F90	0.00% <0.00%> (ø)
src/core/MOM_open_boundary.F90	24.28% <0.00%> (-0.15%)	⬇️
src/tracer/MOM_tracer_advect.F90	58.79% <0.00%> (-0.77%)	⬇️

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

[MJHarrison-GFDL]

Thanks you @WenhaoChen89 for these modifications which allow for the tracer registry and the obc segment tracer registry to function as intended with arbitrary tracer ordering. I agree with the interface modifications as proposed. Given the dependencies involved with other tracer code such as generic_tracers, additional approvals are requested from @nikizadehgfdl

[Hallberg-NOAA]

I have examined these changes and I am convinced that they are correct.

[marshallward]

Gaea regression: https://gitlab.gfdl.noaa.gov/ogrp/MOM6/-/pipelines/20903 ✔️

Squash-merging due to development commits.

[marshallward]

Sorry, I think that I accidentally closed this rather than merge it. Handling it now.