Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ice shelf Coulomb friction law #470

Merged
merged 4 commits into from
Oct 13, 2023
Merged

Conversation

alex-huth
Copy link

Added ice shelf Coulomb friction law (Schoof 2005, Gagliardini et al 2007) needed for MISMIP+ experiments (Asay-Davis et al 2016).

@codecov
Copy link

codecov bot commented Aug 24, 2023

Codecov Report

Merging #470 (4ba2930) into dev/gfdl (38aeccd) will decrease coverage by 0.01%.
The diff coverage is 0.00%.

❗ Current head 4ba2930 differs from pull request most recent head ace1998. Consider uploading reports for the commit ace1998 to get more accurate results

@@             Coverage Diff              @@
##           dev/gfdl     #470      +/-   ##
============================================
- Coverage     37.78%   37.78%   -0.01%     
============================================
  Files           270      270              
  Lines         78434    78447      +13     
  Branches      14525    14528       +3     
============================================
- Hits          29640    29639       -1     
- Misses        43390    43405      +15     
+ Partials       5404     5403       -1     
Files Coverage Δ
src/ice_shelf/MOM_ice_shelf_dynamics.F90 0.00% <0.00%> (ø)

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

…2007) needed for MISMIP+ experiments (Asay-Davis et al 2016).
Copy link
Member

@Hallberg-NOAA Hallberg-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The revisions in this commit all appear to me to be correct.

@marshallward
Copy link
Member

Gaea regression: https://gitlab.gfdl.noaa.gov/ogrp/MOM6/-/pipelines/20913 ✔️

@marshallward marshallward merged commit 89506fa into NOAA-GFDL:dev/gfdl Oct 13, 2023
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants