Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SSA convergence based on change of norm #469

Merged
merged 1 commit into from
Oct 11, 2023

Conversation

alex-huth
Copy link

Added an option NONLIN_SOLVE_ERR_MODE=3 to check for convergence of the ice shelf SSA solution by testing the change of norm, i.e. 2*abs(|u_{t}|-|u_{t-1}|) / (|u_{t}|+|u_{t-1}|)

@codecov
Copy link

codecov bot commented Aug 24, 2023

Codecov Report

Merging #469 (ffbd5fb) into dev/gfdl (41609c2) will decrease coverage by 0.02%.
The diff coverage is 0.00%.

❗ Current head ffbd5fb differs from pull request most recent head a1313aa. Consider uploading reports for the commit a1313aa to get more accurate results

@@             Coverage Diff              @@
##           dev/gfdl     #469      +/-   ##
============================================
- Coverage     37.81%   37.80%   -0.02%     
============================================
  Files           270      270              
  Lines         78381    78403      +22     
  Branches      14515    14521       +6     
============================================
- Hits          29639    29638       -1     
- Misses        43339    43361      +22     
- Partials       5403     5404       +1     
Files Coverage Δ
src/ice_shelf/MOM_ice_shelf_dynamics.F90 0.00% <0.00%> (ø)

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Added an option NONLIN_SOLVE_ERR_MODE=3 to check for convergence of the ice shelf SSA solution by testing the change of norm, i.e. 2*abs(|u_{t}|-|u_{t-1}|) / (|u_{t}|+|u_{t-1}|)
Copy link
Member

@Hallberg-NOAA Hallberg-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have examined these changes, and they look correct to me.

@Hallberg-NOAA
Copy link
Member

This PR has passed pipeline testing at https://gitlab.gfdl.noaa.gov/ogrp/MOM6/-/pipelines/20897.

@Hallberg-NOAA Hallberg-NOAA merged commit 2ac48a6 into NOAA-GFDL:dev/gfdl Oct 11, 2023
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants