Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Resolve warning about S_REF units #425

Merged
merged 2 commits into from
Aug 21, 2023
Merged

Resolve warning about S_REF units #425

merged 2 commits into from
Aug 21, 2023

Commits on Jul 25, 2023

  1. Resolve warning about S_REF units 

    The units of S_REF were first registered in "PSU" and then later by
benchmark in "ppt" which led to a WARNING. Although there is no uniformity
to the units of S_REF throughout the user code (currently PSU, ppt, and 1e-3)
are all used, benchmark is the only one that leads to a warning in the current
suite and changing all to be consistent would 1) unnecessarily update the doc
files, and 2) not be correct for all models. Bottom line, I'm punting on
the best way to handle units of salinity. This commit resolves the only WARNING
we currently get in the MOM6-examples suite.
    @adcroft
    adcroft committed Jul 25, 2023
    Configuration menu
    Copy the full SHA
    5117a32 View commit details
    Browse the repository at this point in the history

Commits on Aug 21, 2023

  1. Merge branch 'dev/gfdl' into user-benchmark-s-unit

    @marshallward
    marshallward authored Aug 21, 2023
    Configuration menu
    Copy the full SHA
    11dd301 View commit details
    Browse the repository at this point in the history