Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

+(*)Fix wave_speed_init mono_N2_depth bug #413

Merged
merged 2 commits into from
Jul 24, 2023
Merged

+(*)Fix wave_speed_init mono_N2_depth bug #413

merged 2 commits into from
Jul 24, 2023

Commits on Jul 24, 2023

  1. +(*)Fix wave_speed_init mono_N2_depth bug 

      Fixed a bug in which wave_speed_init was effectively discarding any values of
mono_N2_depth passed to it via the optional argument mono_N2_depth, but also
changed the default value of RESOLN_N2_FILTER_DEPTH, which was previously being
discarded, to disable the monotonization and replicate the previous results.
There were also clarifying additions made to the description how to disable
RESOLN_N2_FILTER_DEPTH.  This will change some entries in MOM_parameter_doc
files, and it will change solutions in cases that set RESOLN_N2_FILTER_DEPTH to
a non-default value and have parameter settings that use the resolution function
to scale their horizontal mixing.  There are, however, no known active
simulations where the answers are expected to change.
    @Hallberg-NOAA
    Hallberg-NOAA committed Jul 24, 2023
    Configuration menu
    Copy the full SHA
    ed0a9d1 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'dev/gfdl' into wave_speed_init_mono_depth_bugfix

    @marshallward
    marshallward authored Jul 24, 2023
    Configuration menu
    Copy the full SHA
    1e03e98 View commit details
    Browse the repository at this point in the history