Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct --with-driver args for coupled tests #106

Merged

Conversation

adcroft
Copy link
Member

@adcroft adcroft commented Apr 9, 2022

  • Ever since a renaming of driver directories, the tests under "test-top-api", that are meant to check we are compatible with
    each "cap", have been failing silently.
  • This fixes the wrong arguments but does not fix the ability to fail silently which is somewhere deep inside mkmf.

- Ever since a renaming of driver directories, the tests under
  "test-top-api", that are meant to check we are compatible with
  each "cap", have been failing silently.
- This fixes the wrong arguments but does not fix the ability
  to fail silently which is somewhere deep inside mkmf.
@adcroft adcroft added the bug Something isn't working label Apr 9, 2022
@codecov
Copy link

codecov bot commented Apr 9, 2022

Codecov Report

Merging #106 (f92f89b) into dev/gfdl (6809ee3) will not change coverage.
The diff coverage is n/a.

❗ Current head f92f89b differs from pull request most recent head 136c413. Consider uploading reports for the commit 136c413 to get more accurate results

@@            Coverage Diff            @@
##           dev/gfdl     #106   +/-   ##
=========================================
  Coverage     28.75%   28.75%           
=========================================
  Files           248      248           
  Lines         72970    72970           
=========================================
  Hits          20979    20979           
  Misses        51991    51991           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6809ee3...136c413. Read the comment docs.

Copy link
Member

@Hallberg-NOAA Hallberg-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because this does not alter any of the code that would be exercised by the pipeline testing, the successful TC testing is sufficient in this case.

@Hallberg-NOAA Hallberg-NOAA merged commit c150f37 into NOAA-GFDL:dev/gfdl Apr 10, 2022
@adcroft adcroft deleted the fix-github-ci-coupled-api-tests branch May 31, 2022 17:28
marshallward pushed a commit that referenced this pull request Feb 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants