Skip to content

Commit

Permalink
Resolve warning about S_REF units
Browse files Browse the repository at this point in the history
The units of S_REF were first registered in "PSU" and then later by
benchmark in "ppt" which led to a WARNING. Although there is no uniformity
to the units of S_REF throughout the user code (currently PSU, ppt, and 1e-3)
are all used, benchmark is the only one that leads to a warning in the current
suite and changing all to be consistent would 1) unnecessarily update the doc
files, and 2) not be correct for all models. Bottom line, I'm punting on
the best way to handle units of salinity. This commit resolves the only WARNING
we currently get in the MOM6-examples suite.
  • Loading branch information
adcroft authored and marshallward committed Aug 21, 2023
1 parent d107737 commit 5afb122
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion src/user/benchmark_initialization.F90
Original file line number Diff line number Diff line change
Expand Up @@ -142,7 +142,7 @@ subroutine benchmark_initialize_thickness(h, depth_tot, G, GV, US, param_file, e
units="degC", default=29.0, scale=US%degC_to_C, do_not_log=just_read)
call get_param(param_file, mdl, "S_REF", S_ref, &
"The uniform salinities used to initialize the benchmark test case.", &
units="ppt", default=35.0, scale=US%ppt_to_S, do_not_log=just_read)
units="PSU", default=35.0, scale=US%ppt_to_S, do_not_log=just_read)

if (just_read) return ! This subroutine has no run-time parameters.

Expand Down

0 comments on commit 5afb122

Please sign in to comment.