MOM6: +Removed hard newlines in get_param calls #268
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removed hard newlines from numerous get_param and log_param descriptions throughout the MOM6 codebase, relying instead on the new automatic newline capability in writeMessageAndDesc. In the case of formatted lists of options, the hard newlines were retained. This cleans up the code and gives more standard messages and smaller parameter_doc files, but it changes the comments in every MOM_parameter_doc and SIS_parameter_doc file. All answers are bitwise identical. This also corrects some updates to MOM_parameter_doc.all files that were omitted in a recent hand-merge. The MOM6 commit in this PR is: - NOAA-GFDL/MOM6@a236032 +Removed hard newlines in get_param calls
mom6bot
added a commit
to mom6bot/MOM6-examples
that referenced
this pull request
Dec 23, 2022
) - NOAA-GFDL/MOM6@7869030ff Add GL90 parameterization for stacked shallow water (NOAA-GFDL#268)
marshallward
pushed a commit
that referenced
this pull request
Dec 23, 2022
- NOAA-GFDL/MOM6@7869030ff Add GL90 parameterization for stacked shallow water (#268)
mom6bot
added a commit
to mom6bot/MOM6-examples
that referenced
this pull request
Apr 10, 2024
- NOAA-GFDL/MOM6@de59adf02 Make the US argument to MOM_domains_init optional - NOAA-GFDL/MOM6@39368f04d Remove extra & from u/v_smooth - NOAA-GFDL/MOM6@71665fb65 Fix biharmonic leith (NOAA-GFDL#268) - NOAA-GFDL/MOM6@5578478a7 merge latest main and resolve conflicts in mom_cap. - NOAA-GFDL/MOM6@8f73fb2c1 fix intraday CESM restart file names (NOAA-GFDL#267) - NOAA-GFDL/MOM6@ab3b0aaa3 Automated Runtime Land Block Elimination (NOAA-GFDL#263) - NOAA-GFDL/MOM6@dcaadf71d set %label in register_netcdf_field and register_netcdf_axis (NOAA-GFDL#262)
marshallward
pushed a commit
that referenced
this pull request
Apr 10, 2024
- NOAA-GFDL/MOM6@de59adf02 Make the US argument to MOM_domains_init optional - NOAA-GFDL/MOM6@39368f04d Remove extra & from u/v_smooth - NOAA-GFDL/MOM6@71665fb65 Fix biharmonic leith (#268) - NOAA-GFDL/MOM6@5578478a7 merge latest main and resolve conflicts in mom_cap. - NOAA-GFDL/MOM6@8f73fb2c1 fix intraday CESM restart file names (#267) - NOAA-GFDL/MOM6@ab3b0aaa3 Automated Runtime Land Block Elimination (#263) - NOAA-GFDL/MOM6@dcaadf71d set %label in register_netcdf_field and register_netcdf_axis (#262)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed hard newlines from numerous get_param and log_param descriptions
throughout the MOM6 codebase, relying instead on the new automatic newline
capability in writeMessageAndDesc. In the case of formatted lists of options,
the hard newlines were retained. This cleans up the code and gives more standard
messages and smaller parameter_doc files, but it changes the comments in every
MOM_parameter_doc and SIS_parameter_doc file. All answers are bitwise identical.
This also corrects some updates to MOM_parameter_doc.all files that were omitted
in a recent hand-merge. The MOM6 commit in the corresponding MOM6 PR (https://github.com/NOAA-GFDL/MOM6/pull/927) is: