Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorporate ecflow feedback from NCO - part 1 #564

Merged
merged 1 commit into from
Jan 12, 2022
Merged

Incorporate ecflow feedback from NCO - part 1 #564

merged 1 commit into from
Jan 12, 2022

Conversation

aerorahul
Copy link
Contributor

@aerorahul aerorahul commented Jan 12, 2022 •
edited
Loading

This PR incorporates feedback from NCO on scripts in ecf/include. Specifically:

  • reverts head.h to NCO version.
  • removes module loads from head.h (leaves module reset)
  • reverts tail.h to NCO version
  • reverts envir-p1.h to NCO version
  • deletes obsolete envir-p3.h
  • deletes obsolete model_ver.h

This work is part of #398

Including @WeiWei-NCO to gather feedback.

KateFriedman-NOAA
KateFriedman-NOAA approved these changes Jan 12, 2022
View reviewed changes
Copy link
Member

@KateFriedman-NOAA KateFriedman-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Requested head.h changes look good. Can't comment on other changes but my understanding is that these files won't be used by NCO anyway so it's for dev use only.

@KateFriedman-NOAA KateFriedman-NOAA merged commit daa54da into feature/ops-wcoss2 Jan 12, 2022
@KateFriedman-NOAA KateFriedman-NOAA deleted the feature/nco-ecflow-feedback branch January 12, 2022 20:57
kayeekayee pushed a commit to kayeekayee/global-workflow that referenced this pull request May 30, 2024
@BrianCurtis-NOAA
fix for Aerosols (4d vars) causing PET log errors. Update CCPP Framew…
5973dcc 
…ork to support IAP model (NOAA-EMC#564)

* fix for Aerosols (4d vars) causing PET log errors
* Update CCPP Framework to support IAP model
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KateFriedman-NOAA KateFriedman-NOAA KateFriedman-NOAA approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aerorahul @KateFriedman-NOAA