Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increased the No. of default levels to 40 #2953

Closed
wants to merge 1 commit into from

Conversation

AminIlia-NOAA
Copy link

@AminIlia-NOAA AminIlia-NOAA commented Sep 24, 2024

Description

GFSv17 and GEFSv13 require 40 levels for 3D variables for operational forecast . The default levels in case user doesn't define number of levels was 12 in the shell. I suggest to increase the levels to 40 as modified in this shell code (line238).

Resolves #1234

Type of change

  • Bug fix (fixes something broken)
  • New feature (adds functionality)
  • Maintenance (code refactor, clean-up, new CI test, etc.)

Change characteristics

  • Is this a breaking change (a change in existing functionality)? NO
  • Does this change require a documentation update? NO
  • Does this change require an update to any of the following submodules? NO
    • EMC verif-global
    • GDAS
    • GFS-utils
    • GSI
    • GSI-monitor
    • GSI-utils
    • UFS-utils
    • UFS-weather-model
    • wxflow

How has this been tested?

Checklist

  • Any dependent changes have been merged and published
  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have documented my code, including function, input, and output descriptions
  • My changes generate no new warnings
  • New and existing tests pass with my changes
  • This change is covered by an existing CI test or a new one has been added
  • I have made corresponding changes to the system documentation if necessary

@AminIlia-NOAA AminIlia-NOAA marked this pull request as draft September 24, 2024 17:39
@AminIlia-NOAA AminIlia-NOAA marked this pull request as ready for review September 24, 2024 17:40
@@ -235,7 +235,9 @@ component=${1:?"Need a valid component; options: ice|ocean"}
grid=${2:-"0p25"} # Default to 0.25-degree grid
current_cycle=${3:-"2013100100"} # Default to 2013100100
avg_period=${4:-"0-6"} # Default to 6-hourly average
ocean_levels=${5:-"5:15:25:35:45:55:65:75:85:95:105:115:125"} # Default to 12-levels
ocean_levels=${5:-"5:15:25:35:45:55:65:75:85:95:105:115\
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, Thanks for clarification!

@aerorahul
Copy link
Contributor

@AminIlia-NOAA
Apologies. The script is used. I thought I was looking at the gfs-utils.
One note, on the levels, for mx500, the number of levels are 25. Changing to 40 will cause a failure when generating ocean products at mx500 resolution. I believe that is why the default number of levels were capped at 12.
The operational system will use 40 levels, as prescribed by the yaml configuration here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants