Add no_nsst CCPP suites #69
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I believe it is safe to merge this PR already (but not yet the ufs-weather-model). But we can also wait until all tests are completed. |
I believe so, but let's get these suite files tested before we commit them. |
|
I need to create a new baseline on hera first and ask you to move it. Will take a bit. Cheyenne+GNU is running. |
DusanJovic-NOAA
approved these changes
Feb 19, 2020
|
All tests pass, this PR is ready to merge. |
junwang-noaa
approved these changes
Feb 20, 2020
|
Dom,
This pull request is merged, you can update the submodule in
ufs-weather-model pull requests. Thanks a lot for adding these two no nsst
tests.
Jun
…On Wed, Feb 19, 2020 at 6:02 PM Dom Heinzeller ***@***.***> wrote:
All tests pass, this PR is ready to merge.
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub
<#69?email_source=notifications&email_token=AI7D6TORSMBJGWCMTIJB5WTRDW3BLA5CNFSM4KXRVIZ2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEMKBOEA#issuecomment-588519184>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AI7D6TNAZKQLWCRQJ4ZOV43RDW3BLANCNFSM4KXRVIZQ>
.
|
|
Done, please go ahead and merge this PR - thanks, Jun! |
Closed
SamuelTrahanNOAA
referenced
this pull request
in SamuelTrahanNOAA/fv3atm
Jun 13, 2022
…elop_20210331 Update gsl/develop from develop 2021/03/31
LarissaReames-NOAA
pushed a commit
to LarissaReames-NOAA/fv3atm
that referenced
this pull request
Nov 17, 2023
Fix for GNU compiler
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on #67, but use different names (no_nsst instead of no_NST).
Associated PR: ufs-community/ufs-weather-model#61 - see there for testing.