-
Notifications
You must be signed in to change notification settings - Fork 155
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Write restart files using the write grid component #629
Merged
BrianCurtis-NOAA
merged 26 commits into
NOAA-EMC:develop
from
DusanJovic-NOAA:quilting_restart
Mar 28, 2023
Merged
Write restart files using the write grid component #629
BrianCurtis-NOAA
merged 26 commits into
NOAA-EMC:develop
from
DusanJovic-NOAA:quilting_restart
Mar 28, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add module_write_restart_netcdf.F90 Add fv_ufs_restart_io_mod to dycore Compute checkcums in phy and sfc restart output
* added 'quilting_restart' model_configure option * output last restart files without timestamp * fix inline post * support parallel option in write_restart_netcdf
…stGrid to local PETs
37 tasks
junwang-noaa
reviewed
Mar 1, 2023
* Remove unused operator (==) and date_to_string from atmos_model.F90 * Delete unnecessary debug prints
junwang-noaa
approved these changes
Mar 16, 2023
@DusanJovic-NOAA cubed sphere pr was merged. can you update submodule pointer and revert change in gitmodules? |
jkbk2004
approved these changes
Mar 28, 2023
BrianCurtis-NOAA
approved these changes
Mar 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds support for writing restart files using the write grid component.
For each restart file an esmf field bundle is created and populated with esmf fields, which use native Fortran pointers that point to buffers into which all data required are copied from both physics and dynamics internal states.
This is enabled by setting new logical parameter in 'model_configure', named restart_quilting to .true.
Issue(s) addressed
Link the issues to be closed with this PR, whether in this repository, or in another repository.
(Remember, issues should always be created before starting work on a PR branch!)
Testing
How were these changes tested? Regression test on Hera and Orion.
What compilers / HPCs was it tested with? Intel
Are the changes covered by regression tests? Yes.
Have the ufs-weather-model regression test been run? Yes. On what platform? Hera and Orion
Dependencies
If testing this branch requires non-default branches in other repositories, list them.
Those branches should have matching names (ideally)
Do PRs in upstream repositories need to be merged first?
If so add the "waiting for other repos" label and list the upstream PRs