Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Read bucket either as an integer or float #984

Merged
merged 7 commits into from
Jul 4, 2024
Merged

Read bucket either as an integer or float #984

merged 7 commits into from
Jul 4, 2024

Conversation

WenMeng-NOAA
Copy link
Collaborator

@WenMeng-NOAA WenMeng-NOAA commented Jun 27, 2024 •
edited
Loading

The main changes are:

  • Capability of reading bucket (fhzero) from model either as an integer or float.
  • Prevent undefined PBLHGUST involved in calculation

@WenMeng-NOAA WenMeng-NOAA linked an issue Jun 27, 2024 that may be closed by this pull request
Read diagnostic accumulation bucket in float #982
Closed
junwang-noaa
junwang-noaa approved these changes Jul 1, 2024
View reviewed changes
Copy link
Contributor

@junwang-noaa junwang-noaa left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code changes look good to me. I assume you have tested the code updates with the latest model output with real number fhzero.

@WenMeng-NOAA
Copy link
Collaborator Author

@FernandoAndrade-NOAA You may start the UPP RTs on Hera and Orion. There should be no baseline update.

@WenMeng-NOAA
Copy link
Collaborator Author

The UPP RTs were completed on WCOSS2 without changed results.

FernandoAndrade-NOAA
FernandoAndrade-NOAA approved these changes Jul 3, 2024
View reviewed changes
Copy link
Collaborator

@FernandoAndrade-NOAA FernandoAndrade-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RTs on Hera, Hercules and Orion are complete. No changes in results.

@WenMeng-NOAA WenMeng-NOAA added enhancement New feature or request Ready for Review This PR is ready for code review. No Baseline Change No baseline of the UPP regression tests are made. labels Jul 4, 2024
@WenMeng-NOAA
Copy link
Collaborator Author

This PR is ready for merging.

@WenMeng-NOAA WenMeng-NOAA merged commit 6075237 into NOAA-EMC:develop Jul 4, 2024
4 of 5 checks passed
@WenMeng-NOAA WenMeng-NOAA mentioned this pull request Jul 4, 2024
Open
DavidHuber-NOAA added a commit to DavidHuber-NOAA/UPP that referenced this pull request Sep 9, 2024
@DavidHuber-NOAA
Merge remote-tracking branch 'origin/develop' into feature/ss_180
9669aba 
* origin/develop:
  Updates to support MPAS applications (RRFS and HFIP) (NOAA-EMC#1029)
  Add 6-hrly max winds at 10m to SFS (NOAA-EMC#1019)
  Update jet.lua (NOAA-EMC#1027)
  Updates to support UPP use with MPAS (NOAA-EMC#1018)
  [develop]: Turn on WARN_AS_ERROR for Doxygen Documentation Builds (NOAA-EMC#1023)
  Sample PR for testing (NOAA-EMC#1007)
  Enable template 4-49 to obtain aerosol ensemble information (NOAA-EMC#1011)
  Relocate gfs/gefs/sfs control files (NOAA-EMC#990)
  update g2tmp on aws to 1.12.0 (NOAA-EMC#996)
  [develop]: Update requirements files (NOAA-EMC#994)
  Bump zipp from 3.17.0 to 3.19.1 in /doc/UserGuide (NOAA-EMC#991)
  remove stack-python load for Gaea build (NOAA-EMC#993)
  Bump certifi from 2024.2.2 to 2024.7.4 in /doc/UserGuide (NOAA-EMC#988)
  [develop]: Add Doxygen variable definitions to modules (NOAA-EMC#965)
  Read bucket either as an integer or float (NOAA-EMC#984)
  Update Orion module file for Rocky 9 upgrade (NOAA-EMC#987)
  UPP bugfixes for inline post and g2tmpl 1.12.0 compatibility (and number concentration updates) (NOAA-EMC#974)
  Sync the RRFS hotfix NOAA-EMC#967 and NOAA-EMC#968. (NOAA-EMC#979)
  Bump urllib3 from 2.2.1 to 2.2.2 in /doc/UserGuide (NOAA-EMC#981)
  Fix for hydrostatic runs - write out Omega and HGT from model output (NOAA-EMC#959)
  Bump requests from 2.31.0 to 2.32.0 in /doc/UserGuide (NOAA-EMC#963)
  Correct rt.sh paths (NOAA-EMC#957)
  Updates to use GRIB2 template 4.9 for QPFFFG and QPFARI variables in RRFS (NOAA-EMC#929)
  Add hourly averaged smoke PM2.5 and dust PM10 (NOAA-EMC#917)
  Update Namelist documentation for all namelist options (NOAA-EMC#940)
  update gtg code revision to v.4.16.3 (NOAA-EMC#954)
  Bump jinja2 from 3.1.3 to 3.1.4 in /doc/UserGuide (NOAA-EMC#953)
  Clean up labeling for 15-min accumulated fields (NOAA-EMC#948)
  Updates to the GSL exp1 ceiling diagnostic (NOAA-EMC#947)
  Additional RT log information (NOAA-EMC#941)
  add cmake load to modulefile/gaea.lua (NOAA-EMC#945)
  RRFS updates (NOAA-EMC#938)
  add module for AWS (NOAA-EMC#934)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@junwang-noaa junwang-noaa junwang-noaa approved these changes

@FernandoAndrade-NOAA FernandoAndrade-NOAA FernandoAndrade-NOAA approved these changes

@jaymes-kenyon jaymes-kenyon Awaiting requested review from jaymes-kenyon

Assignees
No one assigned
Labels
enhancement New feature or request No Baseline Change No baseline of the UPP regression tests are made. Ready for Review This PR is ready for code review.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Read diagnostic accumulation bucket in float
3 participants
@WenMeng-NOAA @junwang-noaa @FernandoAndrade-NOAA