Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

swap signs on imported fields #4

Merged
merged 3 commits into from
Aug 11, 2023

Conversation

DeniseWorthen
Copy link

@DeniseWorthen DeniseWorthen commented Jun 30, 2023

Within FV3atm, the sign of 4 export fields will be changed at the time they are exported from the ATM. These fields are the momentum stresses, and the sensible and latent heat fluxes. This work is associated with NOAA-EMC/CMEPS#93.

This PR will change make the signs consistently in the HYCOM cap to accommodate the new ATM exports. In testing, this change is B4B for the HAFS RTs in UFS, with the exception of the mediator restart or history files which have differences only of sign, not actual value.

@DeniseWorthen
Copy link
Author

DeniseWorthen commented Jun 30, 2023

@BinLiu-NOAA I'm not sure when this will be needed for the UFS PR, but I wanted to go ahead and put it in so you can take a look.

@DeniseWorthen
Copy link
Author

@BinLiu-NOAA I have a dependent PR for UFS which will require approval prior to starting testing. Thanks.

Copy link

@danrosen25 danrosen25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm fine with this change. It would be nice if the standard name or the field dictionary included directional information so that it's available to the developer.

@BinLiu-NOAA BinLiu-NOAA self-requested a review August 9, 2023 00:29
Copy link

@BinLiu-NOAA BinLiu-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look to me as well.

@BinLiu-NOAA BinLiu-NOAA merged commit 35789c7 into NOAA-EMC:emc/develop Aug 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants