Fixes for GNU compilation issues (from @XiaqiongZhou-NOAA) #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Fixes for mesh generation in init_grid (NOAA-GFDL#39) * Remove trailing whitespace and any tabs * Add default values for nest_*offsets in fv_control
|
Do we have the code updates in tools/fv_grid_tools.F90 for item1:
|
|
This fix is removed in order not to change the baseline. |
actually not, it was removed - I'll update the description. |
bensonr
approved these changes
Jun 19, 2020
This was referenced Jun 19, 2020
Jet build config update, Hera GNU support, FV3 dycore GNU bugfix
ufs-community/ufs-weather-model#151
Merged
junwang-noaa
approved these changes
Jun 21, 2020
XiaqiongZhou-NOAA
approved these changes
Jun 22, 2020
tsupinie
pushed a commit
to tsupinie/GFDL_atmos_cubed_sphere
that referenced
this pull request
Jul 20, 2020
* Fixes for GNU compilation issues (NOAA-GFDL#32) * Fixes for mesh generation in init_grid (NOAA-GFDL#39) * Remove trailing whitespace and any tabs * Add default values for nest_*offsets in fv_control * Remove the fix for mesh generation and it will be fixed later * fix GNU out-of-bound error in driver/fvGFS/atmosphere.F90 * Correct Z dimensions in driver/fvGFS/atmosphere.F90 Co-authored-by: Xiaqiong Zhou <[email protected]>
XiaqiongZhou-NOAA
pushed a commit
to XiaqiongZhou-NOAA/GFDL_atmos_cubed_sphere
that referenced
this pull request
Feb 26, 2021
* remove trailing whitespace and any tabs * update the RELEASE.md with the FV3 technical memorandum * semantic fix in RELEASE.md * adds default values for nest_*offsets in fv_control breaks up a too long line in fv_nesting.F90 * change default value of nestupdate to 7
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes for GNU compilation issues: (NOAA-GFDL#32)
All changes from @XiaqiongZhou-NOAA
Associated PRs:
https://github.com/ufs-community/ufs-weather-model/pull/151/files
NOAA-EMC/fv3atm#131
#22
For regression testing information, see below https://github.com/ufs-community/ufs-weather-model/pull/151/files.