Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update positivity and integrability metadata to conform with new pineappl version #78

Merged
merged 5 commits into from
Aug 8, 2024

Conversation

giacomomagni
Copy link
Contributor

Update positivity and integrability polarized metadata to new pineappl standards.

pyproject.toml Outdated Show resolved Hide resolved
@Radonirinaunimi
Copy link
Member

Radonirinaunimi commented Aug 7, 2024

Given that this requires rather more general changes, #81 should be included here (and is already). We may need to wait for NNPDF/pineappl#302 in case some of the crates are renamed (referring specifically to lumi->channels that would affect this line and this line).

@Radonirinaunimi Radonirinaunimi linked an issue Aug 7, 2024 that may be closed by this pull request
@Radonirinaunimi Radonirinaunimi changed the title Update positivity and integrability metadata Update positivity and integrability metadata to conform with new pineappl version Aug 7, 2024
@felixhekhorn
Copy link
Contributor

I'm not sure you want to wait for pineappl v0.9, it might be good to have a working v0.8 version (for future reference). Then of course we have to have another PR for v0.9 (the moment it is available).

@giacomomagni
Copy link
Contributor Author

I think we can merge this, as it corresponds to the branch used to generate the current theories-

Copy link
Member

@Radonirinaunimi Radonirinaunimi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, agreed!

@giacomomagni giacomomagni merged commit 34cd744 into main Aug 8, 2024
5 checks passed
@giacomomagni giacomomagni deleted the update_pos_metadata branch August 8, 2024 07:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update for new version of pineappl
3 participants