Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce pre-commit hooks #310
base: master
Are you sure you want to change the base?
Introduce pre-commit hooks #310
Changes from all commits
638240c
59289db
e549f67
5620f60
228f35a
d00ad69
f20d246
b992591
77c9d82
00615b0
79b7b1f
6d11bd1
9fbb246
522d943
d848bd4
ced2f8e
ead8262
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In eko we have
cargo clippy
but notcargo check
- which one is better? will eitherfmt
orclippy
runcheck
along the way?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
They are different:
cargo check
is essentially running the compiler, without generating code.cargo clippy
is statically analyzing the code (i.e. the equivalent of Pylint).There is a non-negligible change that
cargo clippy
is a superset ofcargo check
, but it's also possible that they only partially overlap. But this you can search for (or even try: runcargo clippy
on something thatcargo check
was flagging, and see if it's complaining - even a missing;
or unmatched{
).The opposite is definitely impossible:
cargo clippy
may do strictly more, but certainly not strictly less.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, exactly. I did not include
clippy
before because it is very noisy but there is actually some ways to suppress warnings and only show errors.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well: that's certainly an option, but another one is just implementing its suggestions :P
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I agree! I will address this soon #314 😉