Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replace POS_F2 process with more inclusive POS_DIS #2116

Merged
merged 4 commits into from
Jun 26, 2024
Merged

Conversation

RoyStegeman
Copy link
Member

Currently only POS_F2 exists in the PROCESSES dict in process_options.py, so POS_FLL would need to be added as well, that this is missing is simply a bug.

Then, it doesn't make much sense to make POS_FLL exclusive in "heaviness/flavour", while using the more inclusive definition for POS_F2. However, they are both just DIS structure functions so there is no need to separate them by type. Because of this I introduced a single POS_DIS (which only has to supports structure functions and not xsecs).

@RoyStegeman RoyStegeman added the bug Something isn't working label Jun 24, 2024
@RoyStegeman RoyStegeman requested a review from comane June 24, 2024 15:05
@RoyStegeman RoyStegeman changed the title add a general POS_DIS process replace POS_F2 observable with more inclusive POS_DIS Jun 24, 2024
@RoyStegeman RoyStegeman changed the title replace POS_F2 observable with more inclusive POS_DIS replace POS_F2 process with more inclusive POS_DIS Jun 24, 2024
@RoyStegeman
Copy link
Member Author

@comane could you please have a look? The change is very minimal, but perhaps you disagree with it

Copy link
Member

@comane comane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hi @RoyStegeman, thanks for taking care of this!
PR looks good to me now

@RoyStegeman RoyStegeman merged commit 961eac5 into master Jun 26, 2024
6 checks passed
@RoyStegeman RoyStegeman deleted the fix_pos_process branch June 26, 2024 17:09
label: k3
Q2:
description: Factorization scale
label: Q2
units: ''
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess this should be GeV^2

@RoyStegeman RoyStegeman mentioned this pull request Jun 27, 2024
33 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants