Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added NLog 4.6 is live post #99

Merged
merged 19 commits into from
Mar 20, 2019
Merged

Added NLog 4.6 is live post #99

merged 19 commits into from
Mar 20, 2019

Conversation

snakefoot
Copy link
Contributor

@snakefoot snakefoot commented Feb 24, 2019

@snakefoot snakefoot changed the title Create 2019-02-30-nlog-4-6-is-live.md WIP: Create 2019-02-30-nlog-4-6-is-live.md Feb 24, 2019
@304NotModified
Copy link
Member

Thanks in advance!

@snakefoot
Copy link
Contributor Author

snakefoot commented Feb 24, 2019

Guess some example code should be added to the LoggingConfiguration loaded from appsettings.json-headline. Along with an example of JSON-config. See also: NLog/NLog.Extensions.Logging#263

@304NotModified
Copy link
Member

@snakefoot I've added also some sections . Feel free to change the grammar when you spot some mistakes.

```

When using a non-string DbType then it will attempt to convert the raw value directly to the expected type.
When using special DbType like `SqlDbType.SmallInt` then one can specify `parameterType="Int16"` to help.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is indeed important, but maybe it should be only in the wiki and not in the release post. (it is very much in-depth). Is that OK with you?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea. Think I was a little too happy about the change :)

304NotModified and others added 4 commits March 15, 2019 19:41
dependencies on System.Messaging (MSMQ). Since NLog already dependends on System.Configuration
then it didn't make sense also to need NLog.Extended for reading app.config / web.config.

### NLog configuration inside appsettings.json
Copy link
Member

@304NotModified 304NotModified Mar 18, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@snakefoot

We need to merge NLog/NLog.Extensions.Logging#263 first for this?

(and mention NLog.Extensions.Logging 1.5?) -

Doubting if this should be a separate post.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You decide. There is no law saying that the news-posts should be posted on the same day as the release is cut.

@304NotModified 304NotModified changed the title WIP: Create 2019-02-30-nlog-4-6-is-live.md Added NLog 4.6 is live post Mar 20, 2019
@304NotModified 304NotModified merged commit 93d1b8a into NLog:master Mar 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants