-
Notifications
You must be signed in to change notification settings - Fork 165
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Better diagnostics when missing HttpModule or MiddleWare #979
Better diagnostics when missing HttpModule or MiddleWare #979
Conversation
Maybe having the alert in the initialize-section might produce too many false-positives. Ex. loaded NLog configuration, but not yet setup http-pipelines with middleware etc. Maybe it should be the on the first LogEvent where HttpContext is available. Also could it become |
…the middlware/module not being installed.
…only upon first log event. Used double lock pattern.
Changed to first log event |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Think it looks great. Just have some small suggestions.
src/Shared/LayoutRenderers/AspNetRequestPostedBodyLayoutRenderer.cs
Outdated
Show resolved
Hide resolved
src/Shared/LayoutRenderers/AspNetRequestPostedBodyLayoutRenderer.cs
Outdated
Show resolved
Hide resolved
Thank you for the always good suggestions. Modified as suggested. (Have you pondered, when it may be possible to work on items marked as 'breaking changes' in the issues list?) |
SonarCloud Quality Gate failed. 0 Bugs 75.0% Coverage The version of Java (11.0.20) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17. Catch issues before they fail your Quality Gate with our IDE extension SonarLint |
Looks good. Thank you for another nice contribution. |
Uses ctor for middleware and httpmodule, and initializelayoutrender/initializetarget, instead of warning every time, as requested.
Resolves #954 and resolves #953