AspNet Request-Ip with support for CheckForwardedForHeaderOffset #923
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ded-For headers where the desired client IP is NOT at the start of the comma separated list
…lient IP at end, or at 2nd to end, etc of the header
snakefoot
reviewed
Jan 23, 2023
|
Kudos, SonarCloud Quality Gate passed! |
snakefoot
changed the title
|
NLog.Web.AspNetCore v5.2.2 has been released - https://www.nuget.org/packages/NLog.Web.AspNetCore Updated wiki - https://github.com/NLog/NLog/wiki/AspNet-Request-IP-Layout-Renderer |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At the firm I work for, the network engineers have not followed X-Forwarded-For HHTP headers standards.
Instead of having the desired client IP at the start of the list of IP addresses in the header, the client IP is the second or third element, depending upon whether you are in development, test, or production network.
One way to solve this is to add an int Index property to the layout renderer.