Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AspNet Response HttpStatusCode LayoutRenderer as Enum.ToString #921

Merged
merged 4 commits into from
Jan 19, 2023
Merged

AspNet Response HttpStatusCode LayoutRenderer as Enum.ToString #921

merged 4 commits into from
Jan 19, 2023

Conversation

bakgerman
Copy link
Contributor

@bakgerman bakgerman commented Jan 18, 2023 •
edited by snakefoot
Loading

Introduce a Format option, when using Format="d" then it will output integer-value (Default)

Else cast to HttpStatusCode and output the Enum.ToString(Format). Ex. 304 becomes NotModified

Resolves #920

Enable http status code layout renderer to output both the int and En…
0d505c8 
…um.ToString() versions of the status code, using a Format property that defaults to integer.
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

snakefoot
snakefoot approved these changes Jan 19, 2023
View reviewed changes
Copy link
Contributor

@snakefoot snakefoot left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it looks good. Do you have any more changes, before merge ?

@bakgerman
Copy link
Contributor Author

no, i am good with the merge

@snakefoot snakefoot merged commit 3e55f44 into NLog:master Jan 19, 2023
@bakgerman bakgerman deleted the httpstatuscode branch January 19, 2023 20:04
@snakefoot snakefoot mentioned this pull request Jan 19, 2023
Merged
@snakefoot snakefoot changed the title Enable http status code layout renderer to output both the int and En… AspNet Response HttpStatusCode LayoutRenderer as Enum.ToString Jan 23, 2023
@snakefoot snakefoot added this to the 5.2.2 milestone Feb 17, 2023
@snakefoot
Copy link
Contributor

Updated wiki - https://github.com/NLog/NLog/wiki/AspNetResponse-StatusCode-Layout-Renderer

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@snakefoot snakefoot snakefoot approved these changes

Assignees
No one assigned
Labels
enhancement size/L
Projects
None yet
Milestone
5.2.2
Development

Successfully merging this pull request may close these issues.

Extend ${aspnet-response-statuscode} to include Enum-ToString value
2 participants
@bakgerman @snakefoot