Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip allocating RouteData when only need to lookup single value #891

Merged
merged 1 commit into from
Nov 26, 2022

Conversation

snakefoot
Copy link
Contributor

@snakefoot snakefoot commented Nov 26, 2022

Optimizing:

  • AspNetMvcActionRenderer - ${aspnet-mvc-action}
  • AspNetMvcControllerRenderer - ${aspnet-mvc-controller}
  • AspNetRequestRouteParametersRenderer - ${aspnet-request-routeparameters}

@codecov-commenter
Copy link

codecov-commenter commented Nov 26, 2022

Codecov Report

Base: 70% // Head: 69% // Decreases project coverage by -0% ⚠️

Coverage data is based on head (f2a81f0) compared to base (0176c44).
Patch coverage: 13% of modified lines in pull request are covered.

Additional details and impacted files
@@          Coverage Diff          @@
##           master   #891   +/-   ##
=====================================
- Coverage      70%    69%   -0%     
=====================================
  Files          65     65           
  Lines        1218   1229   +11     
  Branches      308    315    +7     
=====================================
+ Hits          850    852    +2     
- Misses        229    236    +7     
- Partials      139    141    +2     
Impacted Files Coverage Δ
...tRenderers/AspNetRequestRouteParametersRenderer.cs 14% <8%> (+4%) ⬆️
.../Shared/LayoutRenderers/AspNetMvcActionRenderer.cs 67% <33%> (-13%) ⬇️
...red/LayoutRenderers/AspNetMvcControllerRenderer.cs 67% <33%> (-13%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 3 Code Smells

90.5% 90.5% Coverage
0.0% 0.0% Duplication

@snakefoot snakefoot merged commit cd89331 into NLog:master Nov 26, 2022
@snakefoot snakefoot added this to the 5.2 milestone Nov 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants