-
Notifications
You must be signed in to change notification settings - Fork 165
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add aspnet-request-servervariable and aspnet-request-item layout renders #811
Conversation
Codecov Report
@@ Coverage Diff @@
## master #811 +/- ##
=====================================
- Coverage 70% 69% -0%
=====================================
Files 62 64 +2
Lines 1146 1159 +13
Branches 289 294 +5
=====================================
+ Hits 797 801 +4
- Misses 225 231 +6
- Partials 124 127 +3
Continue to review full report at Codecov.
|
Maybe introduce a dedicated layoutrenderer. Ex. |
Yes I see, that makes sense. I will do that. |
Added aspnet-request-servervariable and also added aspnet-request-item since I did not see that one either. |
src/Shared/LayoutRenderers/AspNetRequestServerVariableLayoutRenderer.cs
Outdated
Show resolved
Hide resolved
src/Shared/LayoutRenderers/AspNetRequestServerVariableLayoutRenderer.cs
Outdated
Show resolved
Hide resolved
src/Shared/LayoutRenderers/AspNetRequestServerVariableLayoutRenderer.cs
Outdated
Show resolved
Hide resolved
src/Shared/LayoutRenderers/AspNetRequestServerVariableLayoutRenderer.cs
Outdated
Show resolved
Hide resolved
Fixing a unit test |
nuget.org has decided that github.com makes too many requests. This is the error from Appveyor build: Retrying 'FindPackagesByIdAsync' for source 'https://api.nuget.org/v3-flatcontainer/microsoft.sourcelink.common/index.json'. |
src/NLog.Web.AspNetCore/LayoutRenderers/AspNetConnectionActiveTransferFormatLayoutRenderer.cs
Outdated
Show resolved
Hide resolved
src/NLog.Web.AspNetCore/LayoutRenderers/AspNetConnectionHttpTransportTypeLayoutRenderer.cs
Outdated
Show resolved
Hide resolved
src/NLog.Web.AspNetCore/LayoutRenderers/AspNetConnectionHttpTransportTypeLayoutRenderer.cs
Outdated
Show resolved
Hide resolved
src/NLog.Web.AspNetCore/LayoutRenderers/AspNetConnectionInherentKeepAliveLayoutRenderer.cs
Outdated
Show resolved
Hide resolved
src/NLog.Web.AspNetCore/LayoutRenderers/AspNetConnectionInherentKeepAliveLayoutRenderer.cs
Outdated
Show resolved
Hide resolved
src/NLog.Web.AspNetCore/LayoutRenderers/AspNetConnectionProtocolErrorCodeLayoutRenderer.cs
Outdated
Show resolved
Hide resolved
src/NLog.Web.AspNetCore/LayoutRenderers/AspNetConnectionStreamIdLayoutRenderer.cs
Outdated
Show resolved
Hide resolved
...Log.Web.AspNetCore/LayoutRenderers/AspNetConnectionSupportedTransferFormatsLayoutRenderer.cs
Outdated
Show resolved
Hide resolved
src/Shared/LayoutRenderers/AspNetRequestServerVariableLayoutRenderer.cs
Outdated
Show resolved
Hide resolved
src/Shared/LayoutRenderers/AspNetRequestServerVariableLayoutRenderer.cs
Outdated
Show resolved
Hide resolved
tests/Shared/LayoutRenderers/AspNetRequestItemLayoutRendererTests.cs
Outdated
Show resolved
Hide resolved
Kudos, SonarCloud Quality Gate passed! |
Thank you again for being patient with me, and resolving all my nitpicks. |
Hrmm just discovered this baby |
Thank you for being patient with me also. |
I did not see that AspNetItemValueLayoutRenderer either. (That is where the proper naming helps). |
Created #814 |
Yes naming is a hard dicipline. Always a good idea to ask a friend. |
Most of the server variables can be done with other layout render, but some like APP_POOL_ID are only in server variable collection. See https://docs.microsoft.com/en-us/previous-versions/iis/6.0-sdk/ms524602(v=vs.90)
(I change the title of the pull request to match the actual commit now).