Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include ContentRootPath when scanning for NLog.config candidate #749

Merged
merged 1 commit into from
Jan 8, 2022

Conversation

snakefoot
Copy link
Contributor

Resolves #748

@snakefoot snakefoot added this to the 5.0 milestone Jan 8, 2022
@snakefoot snakefoot closed this Jan 8, 2022
@snakefoot snakefoot reopened this Jan 8, 2022
@codecov-commenter
Copy link

codecov-commenter commented Jan 8, 2022

Codecov Report

Merging #749 (3e2abf3) into master (68d615d) will increase coverage by 0%.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #749   +/-   ##
=====================================
  Coverage      63%    63%           
=====================================
  Files          49     49           
  Lines         834    834           
  Branches      206    206           
=====================================
+ Hits          522    526    +4     
+ Misses        238    233    -5     
- Partials       74     75    +1     
Impacted Files Coverage Δ
...utRenderers/AspNetRequestDurationLayoutRenderer.cs 64% <0%> (+9%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 68d615d...3e2abf3. Read the comment docs.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Jan 8, 2022

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

62.5% 62.5% Coverage
0.0% 0.0% Duplication

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Include ContentRootPath as candidate-path for loading NLog.config
2 participants