Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed format Culture to InvariantCulture to match default NLog Culture #735

Merged
merged 1 commit into from
Dec 2, 2021

Conversation

snakefoot
Copy link
Contributor

Resolves #733

@snakefoot snakefoot added this to the 5.0 milestone Nov 30, 2021
@snakefoot snakefoot changed the title Changed format Culture to CultureInfo.InvariantCulture to match default NLog Culture Changed format Culture to InvariantCulture to match default NLog Culture Nov 30, 2021
@snakefoot snakefoot closed this Dec 2, 2021
@snakefoot snakefoot reopened this Dec 2, 2021
@codecov-commenter
Copy link

codecov-commenter commented Dec 2, 2021

Codecov Report

Merging #735 (516a2e3) into master (d3f0657) will decrease coverage by 0%.
The diff coverage is 89%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #735   +/-   ##
=====================================
- Coverage      62%    62%   -0%     
=====================================
  Files          45     45           
  Lines         783    779    -4     
  Branches      188    188           
=====================================
- Hits          487    483    -4     
  Misses        227    227           
  Partials       69     69           
Impacted Files Coverage Δ
...utRenderers/AspNetRequestDurationLayoutRenderer.cs 64% <75%> (ø)
...tRenderers/AspNetApplicationValueLayoutRenderer.cs 80% <100%> (+5%) ⬆️
...d/LayoutRenderers/AspNetItemValueLayoutRenderer.cs 91% <100%> (-2%) ⬇️
...ayoutRenderers/AspNetSessionValueLayoutRenderer.cs 86% <100%> (-3%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d3f0657...516a2e3. Read the comment docs.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Dec 2, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

94.1% 94.1% Coverage
0.0% 0.0% Duplication

@snakefoot snakefoot merged commit c1c8a98 into NLog:master Dec 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix AspNetItemValueLayoutRenderer Culture to be InvariantCulture by default
2 participants