Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LogManager.Setup() - Support for RegisterNLogWeb + RegisterAspNetLayoutRenderer #734

Merged
merged 1 commit into from
Dec 2, 2021

Conversation

snakefoot
Copy link
Contributor

Resolves #732

@snakefoot snakefoot added this to the 5.0 milestone Nov 30, 2021
@codecov-commenter
Copy link

codecov-commenter commented Nov 30, 2021

Codecov Report

Merging #734 (083ca69) into master (d3f0657) will increase coverage by 3%.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #734   +/-   ##
=====================================
+ Coverage      62%    65%   +3%     
=====================================
  Files          45     47    +2     
  Lines         783    788    +5     
  Branches      188    188           
=====================================
+ Hits          487    514   +27     
+ Misses        227    206   -21     
+ Partials       69     68    -1     
Impacted Files Coverage Δ
src/NLog.Web/Config/SetupBuilderExtensions.cs 100% <100%> (ø)
...Log.Web/Config/SetupExtensionsBuilderExtensions.cs 100% <100%> (ø)
...utRenderers/AspNetRequestDurationLayoutRenderer.cs 58% <0%> (-7%) ⬇️
...hared/LayoutRenderers/NLogWebFuncLayoutRenderer.cs 80% <0%> (+30%) ⬆️
...b/Targets/Wrappers/AspNetBufferingTargetWrapper.cs 44% <0%> (+44%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d3f0657...083ca69. Read the comment docs.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Dec 2, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@snakefoot snakefoot merged commit dbc54b9 into NLog:master Dec 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create fluent extension method for LogFactory.Setup() for NLog.Web ASP.NET
2 participants