Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable deterministic build #639

Merged
merged 2 commits into from
Feb 27, 2021
Merged

Enable deterministic build #639

merged 2 commits into from
Feb 27, 2021

Conversation

304NotModified
Copy link
Member

@304NotModified 304NotModified added this to the 4.10.1 milestone Feb 26, 2021
@304NotModified
Copy link
Member Author

304NotModified commented Feb 26, 2021 •
edited
Loading

it's still <repository type="git" url="git://github.com/NLog/NLog.Web" />, without commit. Same for aspnetcore package. Strange as NLog/NLog.Extensions.Logging#479 works

checked this build

@304NotModified 304NotModified marked this pull request as draft February 26, 2021 21:34
@304NotModified
Copy link
Member Author

Was still missing this: #642

@304NotModified 304NotModified marked this pull request as ready for review February 27, 2021 14:11
@304NotModified
Copy link
Member Author

304NotModified commented Feb 27, 2021 •
edited
Loading

testing this with:

@304NotModified
Copy link
Member Author

almost:

image

@304NotModified
Copy link
Member Author

same asp.netcore package:

image

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@304NotModified
Copy link
Member Author

new tries:

@304NotModified
Copy link
Member Author

NLog.Web is green 🎉

image

@304NotModified
Copy link
Member Author

also green :)

image

@304NotModified 304NotModified merged commit 3f53da6 into master Feb 27, 2021
@304NotModified 304NotModified deleted the deterministic-build branch February 27, 2021 14:42
@snakefoot
Copy link
Contributor

Wow great work!

@304NotModified 304NotModified added enhancement ASP.NET 4 ASP.NET MVC Classic ASP.NET Core ASP.NET Core - all versions labels Feb 27, 2021
This was referenced Mar 2, 2021
Merged
Closed
This was referenced Mar 12, 2021
Merged
Merged
This was referenced Mar 18, 2021
Closed
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
ASP.NET Core ASP.NET Core - all versions ASP.NET 4 ASP.NET MVC Classic enhancement size/S
Projects
None yet
Milestone
4.11
Development

Successfully merging this pull request may close these issues.
2 participants
@304NotModified @snakefoot