HttpContext - Extended ObjectDisposedException handling #630
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Suppresses
ObjectDisposedException
when HttpContext is no longer active (Avoid crashing when NLog users are wrongly usingThrowExceptions=true
). Usually caused by NLog-users scheduling work on background-thread that is not awaited so it is runnng after HttpRequest has completed.Alternative workaround to awaiting the background-task is to suppress the capture of thread-execution-context, so the HttpContext doesn't travel to the background-thread:
The correct way of handling this is to ensure logging from non-awaited background-tasks doesn't reach Layout-logic that includes
${aspnet-request}
-Layout-logic (Redirect to NLog targets with simple Layout-logic).