Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed: Mixing AddDebug() with a file based NLog configuration no longer works #487

Merged
merged 1 commit into from
Sep 30, 2019
Merged

Fixed: Mixing AddDebug() with a file based NLog configuration no longer works #487

merged 1 commit into from
Sep 30, 2019

Conversation

304NotModified
Copy link
Member

Port of #485 as hotfix

@snakefoot @304NotModified
Fixed bug introduced with IServiceCollection.Replace. Instead use Try…
822f2f5 
…AddEnumerable

# Conflicts:
#	src/NLog.Web.AspNetCore/AspNetExtensions.cs
@304NotModified
Copy link
Member Author

@snakefoot could you please double check this? This is complete, isn't?

@snakefoot
Copy link
Contributor

snakefoot commented Sep 30, 2019 via email

@304NotModified 304NotModified merged commit 536ad5e into master Sep 30, 2019
@304NotModified 304NotModified deleted the hotfix/fix-4.8.5 branch September 30, 2019 21:32
@304NotModified
Copy link
Member Author

Thanks!

This was referenced Sep 30, 2019
Closed
Merged
@snakefoot snakefoot added ASP.NET Core ASP.NET Core - all versions and removed ASP.NET Core 1 labels Jan 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@snakefoot snakefoot Awaiting requested review from snakefoot

Assignees
No one assigned
Labels
ASP.NET Core ASP.NET Core - all versions size/XS
Projects
None yet
Milestone
NLog.Web.AspNetCore 4.8.6
Development

Successfully merging this pull request may close these issues.
2 participants
@304NotModified @snakefoot