Let IHostBuilder AddNLog work correctly with ${configsetting} #484
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
snakefoot
force-pushed
the
master
branch
2 times, most recently
from
7d712e7 to
3444976
Compare
snakefoot
changed the title
| @@ -112,8 +112,11 @@ public static LogFactory ConfigureNLog(this ILoggingBuilder builder, LoggingConf | |||
| /// <param name="configFileName">Path to NLog configuration file, e.g. nlog.config. </param> | |||
| public static ILoggingBuilder AddNLog(this ILoggingBuilder builder, string configFileName) | |||
| { | |||
| ConfigureServicesNLog(null, builder.Services, serviceProvider => serviceProvider.GetService<IConfiguration>()); | |||
| LogManager.LoadConfiguration(configFileName); | |||
| ConfigureServicesNLog(null, builder.Services, (s, c) => | |||
There was a problem hiding this comment.
Please use longer names then s and c. This isn't C ;)
There was a problem hiding this comment.
Found a better way that got rid of short names.
Could you elaborate this a bit? Not sure what we are to improve here. |
My initial version of AddNLog loaded the NLog-config before By delaying the loading of NLog-config until |
304NotModified
changed the title
|
clear! Thanks! |
snakefoot
added
ASP.NET Core
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IHostBuilder AddNLog attempt to setup ConfigSettingLayoutRenderer early
Increase the chance that fluent configuration will work.