Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DNX: Request renderer: Remove ServerVariable from API in ASP.NET5 #40

Closed
wants to merge 1 commit into from
Closed

DNX: Request renderer: Remove ServerVariable from API in ASP.NET5 #40

wants to merge 1 commit into from

Conversation

304NotModified
Copy link
Member

Remove the option from API as ServerVariables are non-existing in ASP.NET 5.

This will give an configexception instead of runtime.

Fixes #39

@codecov-io
Copy link

Current coverage is 49.69%

Merging #40 into master will not affect coverage as of 0c4c1fc

@@            master     #40   diff @@
======================================
  Files           14      14       
  Stmts          163     163       
  Branches        28      28       
  Methods          0       0       
======================================
  Hit             81      81       
  Partial          8       8       
  Missed          74      74

Review entire Coverage Diff as of 0c4c1fc

Uncovered Suggestions

  1. +3.68% via ...ringTargetWrapper.cs#195...200
  2. +3.68% via ...ringTargetWrapper.cs#167...172
  3. +3.07% via ...ringTargetWrapper.cs#89...93
  4. See 7 more...

Powered by Codecov. Updated on successful CI builds.

@304NotModified 304NotModified changed the title Request renderer: Remove ServerVariable from API in ASP.NET5 DNX: Request renderer: Remove ServerVariable from API in ASP.NET5 Apr 2, 2016
@304NotModified 304NotModified modified the milestone: 4.2.2 Apr 2, 2016
@304NotModified
Copy link
Member Author

breaking change?

304NotModified added a commit that referenced this pull request May 24, 2016
@304NotModified
Request renderer: Remove ServerVariable from API in .NET Core
7187b2b 
Remove nonsupported property from API

Fixes #40, fixes #39
304NotModified added a commit that referenced this pull request May 24, 2016
@304NotModified
Request renderer: Remove ServerVariable from API in .NET Core
7ad9b44 
Remove nonsupported property from API

Fixes #40, fixes #39
@304NotModified
Copy link
Member Author

fixed in #59

@304NotModified 304NotModified deleted the no-NotSupportedException-for-ServerVariable branch February 10, 2017 20:22
kvpro929 added a commit to kvpro929/NLog.Web that referenced this pull request Oct 30, 2022
@kvpro929
Request renderer: Remove ServerVariable from API in .NET Core
c787614 
Remove nonsupported property from API

Fixes NLog/NLog.Web#40, fixes NLog/NLog.Web#39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@304NotModified @codecov-io