Removed dependency on Microsoft.AspNetCore.Http.Extensions #312
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #312 +/- ##
======================================
- Coverage 59% 58% -<1%
======================================
Files 31 31
Lines 401 399 -2
Branches 91 95 +4
======================================
- Hits 235 233 -2
+ Misses 129 128 -1
- Partials 37 38 +1
Continue to review full report at Codecov.
|
…ute (Avoid Missing serviceProvider during scanning)
|
@304NotModified Any progress on this review? |
| return items?.Count > 0 && items.Contains(key) ? items[key] : null; | ||
| }; | ||
| #else | ||
| Func<IDictionary<object, object>, string, object> getVal = (items, key) => |
There was a problem hiding this comment.
why Funcs and not private methodes?
There was a problem hiding this comment.
No special reason. Think I was just keeping the existing coding-style.
There was a problem hiding this comment.
I really prefer private method then. Less clutter.
There was a problem hiding this comment.
By private methods do you mean normal methods or local methods (c# 7.0) ?
|
Thanks! |
304NotModified
approved these changes
Aug 30, 2018
304NotModified
modified the milestones:
NLog.Web.AspNetCore 4.6.1,
NLog.Web + NLog.Web.AspNetCore 4.7
snakefoot
added
ASP.NET Core
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Could also be nice to remove "Microsoft.AspNetCore.Http", but it would require removal of
RegisterHttpContextAccessor