Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Value only aspnet request cookie #295

Closed

Conversation

alexangas
Copy link
Contributor

Fixes #294 by adding a "ValuesOnly" option to the ${aspnet-request-cookie} renderer, with associated unit tests.

Also:

  • clarifies naming of some methods/parameters where the word "values" is used
  • fixes some typos / inconsistent spacing

@alexangas
Copy link
Contributor Author

The unit tests are failing because the implementation of GetCookies is different in the renderer between Core and non-Core. I tried to find out what and why but not sure what's happening here.

Is it still necessary to have two different implementations and therefore behaviours?

@304NotModified
Copy link
Member

Is it still necessary to have two different implementations and therefore behaviours?

yes, we prefer to have it implemented on both platforms. Both are maintained.

@alexangas
Copy link
Contributor Author

I've investigated further but still not sure why they are different, I think the clue is here. However it seems to be the Core version that is missing something compared to Full, so in a separate PR I will attempt to fix this functionality in Core and also improve the unit testing side. Then I will finish this PR off. 😄

@alexangas alexangas closed this Jul 4, 2018
@alexangas
Copy link
Contributor Author

As mentioned in previous comment, will come back to this after #299.

@304NotModified
Copy link
Member

need any help on this? :)

@alexangas
Copy link
Contributor Author

I've completed most of it, but need to verify and correct the behaviour of multi-values. I will use the full framework example app recently merged in to do this. Expect to have it completed over the next week sometime.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

aspnet-request-cookie Value Only
2 participants