Fix aspnet-session failing tests

[petemounce]

No description provided.

[304NotModified]

This should not be needed if nlog 4.0.1+ is used?

[petemounce]

I used both the resharper xunit test runner and the ncrunch test runner, and without that, I got

System.ArgumentException: LayoutRenderer cannot be found: 'aspnet-session'
   at NLog.Config.Factory`2.CreateInstance(String name)
   at NLog.Layouts.LayoutParser.ParseLayoutRenderer(ConfigurationItemFactory configurationItemFactory, SimpleStringReader sr)
   at NLog.Layouts.LayoutParser.CompileLayout(ConfigurationItemFactory configurationItemFactory, SimpleStringReader sr, Boolean isNested, String& text)
   at NLog.Layouts.SimpleLayout.set_Text(String value)
   at NLog.Layouts.Layout.op_Implicit(String text)
   at NLog.Web.Tests.LayoutRenderers.AspNetSessionValueLayoutRendererTests.SessionWithCulture()

the packages.config shows NLog 4.0.1.

[304NotModified]

OK thanks, I will try to reproduce it locally first.

You have tested it with NLog 4.0.1? Which Visual Studio and Resharper?

[304NotModified]

tested it locally VS2013 update 5+R# 10.0.2: no problem;

Will try VS2015 also

edit: works also in VS2015

[304NotModified]

@petemounce please add the following code to the erroneous test case

 InternalLogger.LogFile = @"C:\Temp\nlog.web.log";
 InternalLogger.LogLevel = LogLevel.Trace;

and post the log :)

[petemounce]

@304NotModified here you go - it's in petemounce/NLog.Web@2ba53a1921cd675f2885e4413c10a08d02cb2433. I branched from up-to-date master, made the code change, and have posted the log into that commit message.

[304NotModified]

@petemounce I added some comments there. Not sure if you have seen them. If not, I'm not in a hurry, so NP

[codecov-io]

Current coverage is 9.58%

Merging #26 into master will not affect coverage as of 9b23b7b

@@            master    #26   diff @@
=====================================
  Files           12     12       
  Stmts          146    146       
  Branches        34     34       
  Methods          0      0       
=====================================
  Hit             14     14       
  Partial          2      2       
  Missed         130    130       

Review entire Coverage Diff as of 9b23b7b

---

Uncovered Suggestions

1. +4.11% via ...ringTargetWrapper.cs#194...199
2. +3.43% via ...ringTargetWrapper.cs#166...170
3. +3.43% via ...ringTargetWrapper.cs#88...92
4. See 7 more...

Powered by Codecov. Updated on successful CI builds.

[304NotModified]

hey @petemounce, have you seen my comment https://github.com/petemounce/NLog.Web/commit/2ba53a1921cd675f2885e4413c10a08d02cb2433#commitcomment-15895368 ?

[304NotModified]

Hi @petemounce , I think I have fixed the root cause with #52