Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

${aspnet-request-ip} has not been updated to use TryGetRequest #274

Closed
ytzhakov opened this issue Apr 12, 2018 · 8 comments
Closed

${aspnet-request-ip} has not been updated to use TryGetRequest #274

ytzhakov opened this issue Apr 12, 2018 · 8 comments
Labels

Comments

@ytzhakov
Copy link

As a result, it still throws an HttpException with the message: "Request is not available in this context"
Please change it to use TryGetRequest in order to avoid this exception.

@304NotModified
Copy link
Member

I have time to look at this, so will try to fix this

@ytzhakov
Copy link
Author

ytzhakov commented Apr 12, 2018 via email

@304NotModified
Copy link
Member

This is ASP.NET and not ASP.NET Core, isn't?

@304NotModified
Copy link
Member

I've made already a PR :)

@304NotModified 304NotModified added this to the NLog.Web 4.5.3 milestone Apr 12, 2018
@ytzhakov
Copy link
Author

Wow you are quick.
It is ASP.NET, not Core.

@304NotModified
Copy link
Member

It's now publishing.

@304NotModified
Copy link
Member

@ytzhakov
Copy link
Author

this was the fastest issue solving/publishing that I had ever witnessed.
Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants