AspNetRequestPostedBodyLayoutRenderer - Single lookup using TryGetVal…

…ue (#848)
NLog · Aug 9, 2022 · b19cfa1 · b19cfa1
1 parent 9b5b7db
commit b19cfa1
Showing 1 changed file with 6 additions and 19 deletions.
diff --git a/src/Shared/LayoutRenderers/AspNetRequestPostedBodyLayoutRenderer.cs b/src/Shared/LayoutRenderers/AspNetRequestPostedBodyLayoutRenderer.cs
@@ -25,36 +25,23 @@ public class AspNetRequestPostedBodyLayoutRenderer : AspNetLayoutRendererBase
         /// <inheritdoc/>
         protected override void DoAppend(StringBuilder builder, LogEventInfo logEvent)
         {
-            var httpContext = HttpContextAccessor.HttpContext;
-            if (httpContext == null)
-            {
-                return;
-            }
-
-            var items = httpContext.Items;
-            if (items == null)
-            {
-                return;
-            }
-
-            if (httpContext.Items.Count == 0)
+            var items = HttpContextAccessor.HttpContext?.Items;
+            if (items == null || items.Count == 0)
             {
                 return;
             }
 
 #if !ASP_NET_CORE
-            if (!items.Contains(NLogPostedRequestBodyKey))
+            if (items.Contains(NLogPostedRequestBodyKey))
             {
-                return;
+                builder.Append(items[NLogPostedRequestBodyKey] as string);
             }
 #else
-            if (!items.ContainsKey(NLogPostedRequestBodyKey))
+            if (items.TryGetValue(NLogPostedRequestBodyKey, out var value))
             {
-                return;
+                builder.Append(value as string);
             }
 #endif
-
-            builder.Append(items[NLogPostedRequestBodyKey] as string);
         }
     }
 }