Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NLogLoggingConfiguration - Added support for NLog variables #282

Merged
merged 1 commit into from
Apr 3, 2019

Conversation

snakefoot
Copy link
Contributor

@snakefoot snakefoot commented Apr 2, 2019

Example JSON-config:

{
    "NLog": {
        "variables": {
            "var_layout": "${message}",
            "var_encoding": "utf-8"
        },
        "targets": {
            "console": {
                "type": "Console",
                "layout": "${var_layout}"
            },
            "file": {
                "type": "File",
                "layout": "${var_layout}",
                "encoding": "${var_encoding}",
                "fileName": "c:/temp/console-debug.log"
            }
        },
        "rules": [
            {
                "logger": "*",
                "minLevel": "Trace",
                "writeTo": "file,Console"
            }
        ]
    }
}

@codecov
Copy link

codecov bot commented Apr 2, 2019

Codecov Report

Merging #282 into master will increase coverage by 0.53%.
The diff coverage is 87.17%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #282      +/-   ##
==========================================
+ Coverage   69.92%   70.45%   +0.53%     
==========================================
  Files          12       12              
  Lines         941      958      +17     
  Branches      165      170       +5     
==========================================
+ Hits          658      675      +17     
  Misses        221      221              
  Partials       62       62
Impacted Files Coverage Δ
...ensions.Logging/Config/NLogLoggingConfiguration.cs 84.21% <87.17%> (+4.54%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fd54f12...3d48aca. Read the comment docs.

@snakefoot
Copy link
Contributor Author

@304NotModified Ready for review. Would like to continue on with default-wrapper and default-target-parameters

@304NotModified 304NotModified merged commit 4f33779 into NLog:master Apr 3, 2019
@304NotModified 304NotModified added this to the 1.5 milestone Apr 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants