Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable out of tree builds of NSD #245

Merged
merged 4 commits into from
Jan 7, 2025
Merged

Enable out of tree builds of NSD #245

merged 4 commits into from
Jan 7, 2025

Conversation

wtoorop
Copy link
Member

@wtoorop wtoorop commented Dec 23, 2024

wcawijngaards
wcawijngaards approved these changes Jan 3, 2025
View reviewed changes
Copy link
Member

@wcawijngaards wcawijngaards left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change is for the include/zone/export.h file. It is good to support out of tree builds, and the change looks okay.

@wtoorop wtoorop merged commit 966829c into main Jan 7, 2025
9 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wcawijngaards wcawijngaards wcawijngaards approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wtoorop @wcawijngaards