-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add Gram-Schmidt process #11 #15
Conversation
Codecov Report
@@ Coverage Diff @@
## master #15 +/- ##
========================================
+ Coverage 92.1% 92.3% +0.1%
========================================
Files 39 40 +1
Lines 1610 1647 +37
========================================
+ Hits 1484 1521 +37
Misses 126 126
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you want to implement the twice is enough here as well?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
class or not class :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
few things to change but good :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Twice is enough is not implemented yet and Tests for the other orthogonalisation methods are missing.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like all of it, apart form the check_sanity. I think we should split it into two:
Assert_leftColsToSkipRange()
and maybe treatfirstColumn()
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
more small changes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work
#define SPECTRA_ORTHOGONALIZATION_H | ||
|
||
#include <Eigen/Core> | ||
#include <Eigen/Dense> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
#include <Eigen/QR>
seems sufficient. #include <Eigen/Dense>
will also include many heavy solvers such as LU, SVD, etc.
Changes
Add Gram-Schmidt orthonormalization process
implements #11