Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Broken Endpoints #9

Closed
8 tasks done
srmor opened this issue Mar 22, 2016 · 2 comments
Closed
8 tasks done

Broken Endpoints #9

srmor opened this issue Mar 22, 2016 · 2 comments
Assignees
Labels

Comments

@srmor
Copy link
Contributor

srmor commented Mar 22, 2016

  • PUT /update/password
  • PUT /update/email
  • GET /generalUser/:userid
  • POST /login
  • POST /CreateCourse : tries to set a column (Tittle) that doesn’t exist
  • POST /CreateSemester :

Why does it create it with start and end dates that are one day earlier?

{
    "startDate": "1994-10-10",
    "endDate": "1995-12-10",
    "Name": "Test Semester 2",
    "OrganizationID": 1
}

What is an Organization? You have to tell the frontend somehow what the current OrganizationID is

  • The endpoints that change or create data need to throw a 400/401 when correct data isn’t passed not just when the there is a mysql error on your side (i.e. the /update/password endpoint should 401 when the wrong old password is given etc.)
  • When there is a MySQL error you should console log the error and the endpoint it corresponds to because you are getting MySQL errors on the test server causing the server to crash and need to be restarted.
@cga101
Copy link
Contributor

cga101 commented Mar 22, 2016

We're going to drop Organization from the current implementation, as I think it's supposed to be a field for multiple schools (which would currently be out of scope).

There's a Google Doc that contains our db schema for testing/improvements that reflects these changes.

As of 3/22, the following still need changes :
CreateSemester - Assigned to Cesar
Endpoint Validation - Cesar, Hira, and Myself
Console.Log - Cesar, Hira, and Myself

@cesarl88
Copy link
Contributor

cesarl88 commented Apr 2, 2016

PUT /update/password
Tested working

PUT /update/email
Tested working

GET /generalUser/:userid
{
"Error": false,
"Message": "Success",
"User": [
{
"FirstName": "Christian",
"LastName": "Alexander",
"UserType": "Student",
"Email": "[email protected]"
}
]
}

POST /login
{
"Error": false,
"Message": "Success",
"UserID": 3
}

POST /CreateCourse : tries to set a column (Tittle) that doesn’t exist
Tested working
{
"result": [
{
"LAST_INSERT_ID()": 5
}
]
}

POST /CreateSemester :
{
"SemesterID": 6
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants