Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add AVL Tree Data Structure [C] #143

Merged
merged 3 commits into from
Oct 2, 2018
Merged

Add AVL Tree Data Structure [C] #143

merged 3 commits into from
Oct 2, 2018

Conversation

shriakhilc
Copy link
Contributor

Implementation includes insertion and deletion operations along with
pre-order, post-order and in-order traversals.

Closes #47

By submitting this pull request I confirm I've read and complied with the
below declarations.

  • I have read the Contribution guidelines and I am confident that my PR reflects them.
  • I have followed the commit guidelines for this project.
  • My code follows the standard code structure.
  • This pull request has a descriptive title. For example, {Tag}: Add {Algorithm/DS name} [{Language}], not Update README.md or Added new code.
  • This pull request will be closed if I fail to update it even once in a continuous time span of 7 days.
  • This pull request shall only be reviewed and merged once all the checks passes. No maintainer or supporter shall be obliged to review it before this condition is met.
  • I have mentioned the issue number correctly (with hyperlink) in this pull request description.

After you submit your pull request, DO NOT click the 'Update Branch' button.

}

Node* newNode(int val) {
Node* temp = (Node*) malloc(sizeof(Node));
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using C-style cast. Use reinterpret_cast<Node*>(...) instead [readability/casting] [4]

Origin: CPPLintBear, Section: all.cpp.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sangamcse I spotted this when I ran Coala locally, but since this is a C file and that is a CPP specific style guideline, I think it isn't applicable and can be ignored.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@TheGamer007, Include a ignore comment for that.

@sangamcse
Copy link
Member

@sangamcse rebase

@sangamcse
Copy link
Member

Hey! I'm GitMate.io! This pull request is being rebased automatically. Please DO NOT push while rebase is in progress or your changes would be lost permanently ⚠️

shriakhilc and others added 3 commits October 2, 2018 07:24
Implementation includes insertion and deletion operations along with
pre-order, post-order and in-order traversals.

Closes #47
@sangamcse
Copy link
Member

Automated rebase with GitMate.io was successful! 🎉

@sangamcse sangamcse merged commit 27f8287 into NITSkmOS:master Oct 2, 2018
@shriakhilc shriakhilc deleted the avl-tree-c branch October 2, 2018 07:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Data Structure] AVL Tree [C]
2 participants